Rename the Table type's "rows" -> "items" and "columns" -> "attributes" everywhere

[Keavon]

Partly closes #3779.

[cubic-dev-ai]

1 issue found across 24 files

Confidence score: 5/5

• This looks low risk overall: the only noted issue is a low-severity API naming consistency concern (3/10) rather than a functional bug or regression.
• In node-graph/libraries/core-types/src/table.rs, renaming new_from_row to new_from_item (or adding a deprecated alias) helps keep the API aligned with Item semantics and reduces developer confusion.
• Pay close attention to node-graph/libraries/core-types/src/table.rs - ensure the naming change (or compatibility alias) avoids downstream API friction for existing callers.

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="node-graph/libraries/core-types/src/table.rs">

<violation number="1" location="node-graph/libraries/core-types/src/table.rs:884">
P3: Rename `new_from_row` to `new_from_item` (or provide a clearly deprecated compatibility alias) to keep API naming aligned with `Item` semantics.

(Based on your team's feedback about keeping type/function names aligned with their actual responsibilities.) [FEEDBACK_USED]</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[gemini-code-assist]

Code Review

This pull request performs a comprehensive renaming of the Table data structure components to align with a new terminology of "items" and "attributes" instead of "rows" and "columns." Key changes include renaming TableRow to Item, AttributeColumn to AnyAttribute, and updating associated iterators and storage types across the codebase. The review feedback identifies several remaining methods and local variables that still use the old terminology (e.g., clone_row, into_row_vec, new_from_row) and suggests renaming them to maintain consistency with the PR's primary objective.