Skip to content

Fix the Shift-drag alignment guide anchoring to the prior selection instead of the dragged layer#4278

Merged
Keavon merged 1 commit into
masterfrom
fix-shift-drag-alignment-guide-anchor
Jun 23, 2026
Merged

Fix the Shift-drag alignment guide anchoring to the prior selection instead of the dragged layer#4278
Keavon merged 1 commit into
masterfrom
fix-shift-drag-alignment-guide-anchor

Conversation

@Keavon

@Keavon Keavon commented Jun 23, 2026

Copy link
Copy Markdown
Member

Closes #4248

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors how the drag start center is tracked and calculated in the select tool. The static drag_start_center field has been removed from SelectToolData in favor of a dynamically computed dragging_layers_center method. This method calculates the center of the combined viewport-space bounding box of the currently dragged layers. The FSM logic has been updated to use this dynamic calculation, adjusting for drag displacement to keep the guide anchored correctly during viewport auto-panning. There are no review comments, so no feedback is provided.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@Keavon Keavon merged commit ebbbb6b into master Jun 23, 2026
10 checks passed
@Keavon Keavon deleted the fix-shift-drag-alignment-guide-anchor branch June 23, 2026 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Shift drag shows alignment lines at wrong object

1 participant