Fix SVG blend isolation for artboards and thumbnails#4303
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces isolation styling to SVG outputs and artboard groups to prevent blending against the background checkerboard, and refactors artboard background rendering by moving it inside the artwork group. The review feedback points out a correctness issue where removing the x and y offset calculations breaks support for negative artboard dimensions, and provides a code suggestion to calculate local offsets relative to the group's origin.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
There was a problem hiding this comment.
1 issue found across 2 files
Confidence score: 3/5
- In
node-graph/libraries/rendering/src/renderer.rs, negativedimensions.x/dimensions.ycan make the artboard background extend into negative space while the rect still defaults tox=0/y=0, so the background may be mispositioned or clipped for those groups; update the rect origin/size logic to account for negative dimensions before merging.
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Normal situation will not create an artboard with negative dimension as `create_artboard` normalizes it, but it is still better to keep it in the renderer.
Closes #4302
isolation: isolatewhen there is no clipping by the artboard to prevent blending with the background checker pattern. The same applies to thumbnails.