Update UI when deleting last point of shape with Path tool#979
Conversation
…e by delegating deletion to Operation::DeleteLayer. Also emits Operation::DeletedSelectedManipulatorPoints to let editor clear Properties panel
…lectedManipulatorPoints match case. When this DocumentResponse is emitted, it clears the Properties panel.
…tedManipulatorPoints. Updated imports in document_message_handler.rs to get the correct types for messages emitted from DocumentResponse::DeletedSelectedManipulatorPoints match case in process_message().
0HyperCube
approved these changes
Jan 28, 2023
Contributor
0HyperCube
left a comment
0HyperCube
left a comment
There was a problem hiding this comment.
Thanks for the contribution, the code looks good.
…Message::SendLayout's instead, which update the backend widget state
Keavon
changed the title
Keavon
added a commit
that referenced
this pull request
Feb 8, 2023
* Added new DocumentResponse variant * Update Operation::DeleteSelectedManipulatorPoints to update Layer Tree by delegating deletion to Operation::DeleteLayer. Also emits Operation::DeletedSelectedManipulatorPoints to let editor clear Properties panel * Update process_message() to deal with new DocumentResponse::DeletedSelectedManipulatorPoints match case. When this DocumentResponse is emitted, it clears the Properties panel. * Added Display trait implementation for DocumentResponse::DeletedSelectedManipulatorPoints. Updated imports in document_message_handler.rs to get the correct types for messages emitted from DocumentResponse::DeletedSelectedManipulatorPoints match case in process_message(). * Removed useless import. Capitalized comments for style consistency. * Updated messages emitted to clear Properties panel by emitting LayoutMessage::SendLayout's instead, which update the backend widget state * Revert inclusion of unused imports --------- Co-authored-by: Keavon Chambers <keavon@keavon.com>
Keavon
added a commit
that referenced
this pull request
Jul 30, 2023
* Added new DocumentResponse variant * Update Operation::DeleteSelectedManipulatorPoints to update Layer Tree by delegating deletion to Operation::DeleteLayer. Also emits Operation::DeletedSelectedManipulatorPoints to let editor clear Properties panel * Update process_message() to deal with new DocumentResponse::DeletedSelectedManipulatorPoints match case. When this DocumentResponse is emitted, it clears the Properties panel. * Added Display trait implementation for DocumentResponse::DeletedSelectedManipulatorPoints. Updated imports in document_message_handler.rs to get the correct types for messages emitted from DocumentResponse::DeletedSelectedManipulatorPoints match case in process_message(). * Removed useless import. Capitalized comments for style consistency. * Updated messages emitted to clear Properties panel by emitting LayoutMessage::SendLayout's instead, which update the backend widget state * Revert inclusion of unused imports --------- Co-authored-by: Keavon Chambers <keavon@keavon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Operation::DeleteSelectedManipulatorPoints re-routes the deletion logic to Operation::DeleteLayer when you delete the last point in a shape, which updates the Layer Tree structure in the frontend. After it's done deleting it emits a new DocumentResponse, DeletedSelectedManipulatorPoints, and when handled by process_message() in document_message_handler.rs, clears the Properties panel.