feat(cli): support draft number and revision in TBRN #525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 835617688Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
linjiX
requested changes
May 12, 2021
tensorbay/utility/tbrn.py
Outdated
| 'TensorBay Resource Name should add dataset name "tb:<dataset name>"' | ||
| ) | ||
|
|
||
| is_draft = TBRN._DRAFT_SEPARATOR in dataset_name |
There was a problem hiding this comment.
branch and tag may contain #
rexzheng324-c
force-pushed
the
T15191_tbrn_support_ref_and_draft
branch
from
5763cb8 to
b2cdd6c
Compare
linjiX
requested changes
May 12, 2021
linjiX
requested changes
May 12, 2021
tensorbay/utility/tbrn.py
Outdated
| return self._type | ||
|
|
||
| @property | ||
| def is_draft(self) -> int: |
| else: | ||
| names[TBRN._FRAME_INDEX] = "" | ||
| if self.is_draft: | ||
| names[1] = f"{names[1]}{TBRN._DRAFT_SEPARATOR}{self.draft_number}" |
There was a problem hiding this comment.
should not change names[1]
There was a problem hiding this comment.
names is a local variable, can be changed.
tensorbay/utility/tbrn.py
Outdated
| names[TBRN._FRAME_INDEX] = "" | ||
| if self.is_draft: | ||
| names[1] = f"{names[1]}{TBRN._DRAFT_SEPARATOR}{self.draft_number}" | ||
| else: |
linjiX
requested changes
May 12, 2021
| else: | ||
| names[TBRN._FRAME_INDEX] = "" | ||
| if self.is_draft: | ||
| names[1] = f"{names[1]}{TBRN._DRAFT_SEPARATOR}{self.draft_number}" |
There was a problem hiding this comment.
names is a local variable, can be changed.
rexzheng324-c
force-pushed
the
T15191_tbrn_support_ref_and_draft
branch
from
b2cdd6c to
dd03dd7
Compare
rexzheng324-c
changed the title
rexzheng324-c
force-pushed
the
T15191_tbrn_support_ref_and_draft
branch
2 times, most recently
from
ebaa6db to
b583651
Compare
rexzheng324-c
changed the title
rexzheng324-c
force-pushed
the
T15191_tbrn_support_ref_and_draft
branch
2 times, most recently
from
2e6d4fc to
913aa1f
Compare
linjiX
approved these changes
May 12, 2021
linjiX
requested changes
May 12, 2021
| remote_path: Object path of the file. | ||
| tbrn: Full TBRN string. | ||
| draft_number: The draft number (if the status is draft). | ||
| revision: The commit revision (if the status is commit). |
There was a problem hiding this comment.
status is not draft
commit revision -> revision
rexzheng324-c
force-pushed
the
T15191_tbrn_support_ref_and_draft
branch
from
913aa1f to
b4a6f09
Compare
linjiX
approved these changes
May 12, 2021
rexzheng324-c
force-pushed
the
T15191_tbrn_support_ref_and_draft
branch
from
b4a6f09 to
e6ce906
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.