Refractoring the [gravitypdf] shortcode class #930
Merged
jakejackson1 merged 1 commit intodevelopmentfrom May 2, 2019
Merged
Conversation
jakejackson1
force-pushed
the
shortcode-refractor
branch
2 times, most recently
from
5a717e2 to
9877f24
Compare
jakejackson1
force-pushed
the
shortcode-refractor
branch
from
9877f24 to
ec48b50
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refractor the Shortcode class to make it easier to reuse the code for other similar shortcodes
Testing instructions
Checkout the branch and use the [gravitypdf] shortcode like normal. None of the features have changed, just the underlying code structure.
Checklist:
Additional Comments