Restore Interface Contract in DOM.php#41
Merged
jakejackson1 merged 1 commit intomainfrom Dec 11, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #41 +/- ##
============================================
- Coverage 88.40% 88.39% -0.01%
Complexity 1349 1349
============================================
Files 26 26
Lines 3088 3086 -2
============================================
- Hits 2730 2728 -2
Misses 358 358
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
In 35e9266 the $selector property was changed from null to '', which broke the Query interface contract. Restore the contract to prevent a breaking change, and partially revert the $selector defaults back to null
jakejackson1
force-pushed
the
query-contract
branch
from
dddd220 to
86e4bc2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In 35e9266 the $selector property was changed from null to '', which broke the Query interface contract.
Restore the contract, instead of updating the interface, to prevent a breaking change.
Pull Request type
Please check the type of change your PR introduces:
What is the current behavior?
The interface and the class implementing it were at odds with the type hints.
What is the new behavior?
Update the class so it matches the interface.
Does this introduce a breaking change?