Skip to content

Improve accuracy of types in DocBlocks#42

Merged
jakejackson1 merged 1 commit intomainfrom
docblock-type-hinting
Dec 11, 2022
Merged

Improve accuracy of types in DocBlocks#42
jakejackson1 merged 1 commit intomainfrom
docblock-type-hinting

Conversation

@jakejackson1
Copy link
Copy Markdown
Member

Not all DocBlocks had accurate type hints. Also adds a missing docblock to DomQuery::insertAfter()

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 11, 2022

Codecov Report

Merging #42 (d264d91) into main (4280f56) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main      #42   +/-   ##
=========================================
  Coverage     88.40%   88.40%           
  Complexity     1349     1349           
=========================================
  Files            26       26           
  Lines          3088     3088           
=========================================
  Hits           2730     2730           
  Misses          358      358           
Impacted Files Coverage Δ
src/DOMQuery.php 82.00% <ø> (ø)
src/Helpers/QueryMutators.php 95.34% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Also adds a missing docblock to DomQuery::insertAfter()
@jakejackson1 jakejackson1 merged commit 240194a into main Dec 11, 2022
@jakejackson1 jakejackson1 deleted the docblock-type-hinting branch December 11, 2022 10:35
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant