chore(sync): quality-hardening + SDK sessions module, client/tools/types updates#21
Merged
Merged
Conversation
CI mypy --strict flagged two ToolResult() call sites in tools.py for missing the `is_error` named argument, and ruff flagged 13 lint issues in the new sessions.py / test_sessions.py module added in the previous commit. - Pass `is_error=` explicitly at both chat_with_tools entry points, using `bool(tool_name) and tool_name not in tool_map` so unknown tool names are flagged as errors. - Replace deprecated `typing.Dict` / `typing.List` with `dict` /`list` (PEP 585; SDK already targets Python 3.9+ where these work natively). - Drop unused `Optional` import and `typing.Dict` import. - Strip quotes from forward-reference `"Phase"` annotation (UP037). - Replace en-dash in `phase_share` docstring with hyphen-minus (RUF002). - Organize and prune unused imports in tests/test_sessions.py (I001, F401).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sync quality-hardening changes from local-main development to the public
mainbranch in a single auditable PR. Includes:ci: add CODEOWNERS, dependabot.yml, SHA-pinned actions(CI infra)chore: remove dependabot.yml(rotation step)chore: merge quality-hardening into main(CI scoring consolidation)feat: ...(was branched separately in this repo; see commit log)Verification
lefthookpre-push gates (govulncheck,go vet,go test) pass locally. Two trace tests (TestResolveCommitUnambiguous_MultipleCommitMatches,TestPromptYN_ContextCanceled) are flaky under heavy local parallelism; both pass when run in isolation and were green in the prior merged PR for the same files on remote CI.