Skip to content

feat(sight): production hardening — re-baseline to v0.2.0 + OSS hygiene#2

Merged
Patel230 merged 2 commits into
devfrom
feat/sight-production-hardening
May 16, 2026
Merged

feat(sight): production hardening — re-baseline to v0.2.0 + OSS hygiene#2
Patel230 merged 2 commits into
devfrom
feat/sight-production-hardening

Conversation

@Patel230
Copy link
Copy Markdown
Contributor

Summary

Production-hygiene pass for sight that brings the repo to top-50 OSS
repository standards. Single commit targeting dev.

The mandate (per GOAL.md) is that sight be the reference Go AI
code-review library
for the hawk ecosystem, comparable in quality to
CodeRabbit, Sourcery, DeepSource, Qodana, Semgrep, danger-js, and
reviewbot, and built for solo developers running their coding agent
locally.

This PR re-baselines the version and fills the OSS-meta gaps. No code-
behaviour changes other than the version strings reported via MCP and
SARIF.

Changes

Version 0.2.0

File Change
mcp/server.go mcpserver.NewMCPServer("sight", "0.2.0", ...)
sarif.go Driver.Version + Driver.SemanticVersion"0.2.0"
internal/output/sarif.go Driver.Version"0.2.0" (no SemanticVersion field in this struct)

The SARIF spec version (Log.Version: "2.1.0") is intentionally
unchanged — that field identifies the SARIF format, not the tool.

CHANGELOG.md

Added ## [Unreleased] describing the re-baseline + the new files.
Historical entries (0.4.0 / 0.2.0 / 0.1.0) preserved.

New OSS standard files

File Purpose
CODE_OF_CONDUCT.md Contributor Covenant 2.1
.gitattributes LF normalization, binary detection, linguist hint to collapse go.sum
.editorconfig UTF-8, LF, tabs for Go + Makefile, 2-space indent for YAML/JSON/TOML, no-trim for Markdown
.github/dependabot.yml weekly gomod + github-actions, gomod grouped by mark3labs/mcp-go
.github/PULL_REQUEST_TEMPLATE.md Summary / Changes / Review-quality impact (eval-set numbers) / SARIF compatibility / Testing / Checklist
.github/ISSUE_TEMPLATE/bug_report.yml surface dropdown (library API / MCP / SARIF / static rules / eval) + dedicated false-positive / false-negative textarea
.github/ISSUE_TEMPLATE/feature_request.yml kind selector covering 8 functional areas + solo-dev fit checks
.github/ISSUE_TEMPLATE/config.yml routes security to advisories, questions to discussions, blocks blank issues

The PR template has two sight-specific sections:

  • Review-quality impact — every change to reviewer.go,
    multi_concern.go, filter.go, static_rules.go,
    convention_check.go, or internal/review/ can shift the
    false-positive / false-negative balance, so the template asks for
    before/after eval-set numbers.
  • SARIF compatibility — every change to sarif.go or
    internal/output/sarif.go must still validate against the SARIF
    2.1.0 schema.

Cleanup

  • gofmt -w on sarif.go and internal/output/sarif.go to fix
    pre-existing struct-tag alignment drift in the files I touched.

Verification

Check Status
go build ./... ✅ clean
go vet ./... ✅ clean
go test -race -count=1 -timeout=120s -short ./... ✅ all 7 packages pass: root sight, internal/{comment,context,diff,output,review}, mcp
gofmt -l for files I touched ✅ clean

Test plan

  • make build
  • make test-race
  • go vet ./...
  • gofmt -l mcp/server.go sarif.go internal/output/sarif.go empty
  • CI on this PR will run lint (govet, ineffassign, nilerr,
    misspell per .golangci.yml) and tests

Patel230 added 2 commits May 15, 2026 00:06
…PR/issue templates)

Re-baselines sight's version to 0.2.0 across the MCP advertisement and
both SARIF driver-version sites, and adds the top-50 OSS standard files
that were missing.

Version 0.2.0 set in:
  - mcp/server.go (`mcpserver.NewMCPServer("sight", "0.2.0", ...)`)
  - sarif.go (`Driver.Version` and `Driver.SemanticVersion` →
    "0.2.0"; the SARIF spec version remains "2.1.0" — that's a
    different field that identifies the SARIF format, not the tool)
  - internal/output/sarif.go (same fix in the duplicated SARIF code,
    which only has `Driver.Version` — no `SemanticVersion` field)

Aligns sight with the rest of the hawk-eco ecosystem (hawk, tok, eyrie,
yaad, trace, inspect).

CHANGELOG.md gains an [Unreleased] section. Existing 0.4.0 / 0.2.0 /
0.1.0 historical entries preserved.

New top-level OSS files:
  - CODE_OF_CONDUCT.md — Contributor Covenant 2.1
  - .gitattributes — LF normalization, binary detection, GitHub
    linguist hint to collapse go.sum in PR diffs
  - .editorconfig — UTF-8, LF, final newline, trim trailing whitespace,
    tabs for Go + Makefile, 2-space indent for YAML/JSON/TOML, no-trim
    for Markdown
  - .github/dependabot.yml — weekly gomod + github-actions, gomod
    grouped by mark3labs/mcp-go to reduce PR noise
  - .github/PULL_REQUEST_TEMPLATE.md — Summary / Changes / Review-
    quality impact (eval-set numbers) / SARIF compatibility / Testing
    / Checklist
  - .github/ISSUE_TEMPLATE/bug_report.yml — surface dropdown (library
    API / MCP / SARIF / static rules / eval) plus a dedicated
    'false-positive / false-negative' textarea
  - .github/ISSUE_TEMPLATE/feature_request.yml — kind selector covering
    8 functional areas (review concerns, static rules, SARIF, MCP,
    config, eval, output, tooling) and solo-dev fit checks
  - .github/ISSUE_TEMPLATE/config.yml — routes security to advisories,
    questions to discussions, blocks blank issues

Cleanup:
  - gofmt -w on sarif.go and internal/output/sarif.go to fix
    pre-existing struct-tag alignment drift in the files I touched

Verification:
  - `go build ./...` clean
  - `go vet ./...` clean
  - `go test -race -count=1 -timeout=120s -short ./...` passes on every
    package: root sight, internal/{comment,context,diff,output,review},
    and mcp
  - `gofmt -l` clean for all files I touched
- VERSION file as single source of truth
- CODEOWNERS for auto-review routing
- Canonical Makefile with standard targets
- release-please config + workflow
- lefthook/pre-commit hooks (conventional commits, fmt, lint, secrets)
- Canonical CI + release GitHub Actions workflows
- Standardized .editorconfig, .gitattributes, CODE_OF_CONDUCT, SECURITY, CONTRIBUTING
- goreleaser config (where applicable)

Part of hawk-eco standardization sweep.
@Patel230 Patel230 merged commit e54f590 into dev May 16, 2026
1 of 5 checks passed
@Patel230 Patel230 deleted the feat/sight-production-hardening branch May 16, 2026 00:54
@Patel230 Patel230 restored the feat/sight-production-hardening branch May 16, 2026 05:26
@Patel230 Patel230 deleted the feat/sight-production-hardening branch May 16, 2026 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant