This repository was archived by the owner on Mar 21, 2023. It is now read-only.
Mark configuration settings in NetFlowCodec as optional #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While these settings are in fact *not* optional, this seems to be the only way to make existing NetFlow inputs work with the newly added configuration settings without deleting and re-creating the inputs. Fixes #12
bernd
approved these changes
Jul 28, 2017
Member
bernd
left a comment
bernd
left a comment
There was a problem hiding this comment.
I am okay with that. Thank you!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While these settings are in fact not optional, this seems to be the only way to make existing NetFlow inputs work with the newly added configuration settings without deleting and re-creating the inputs.
Fixes #12