Conversation
YoniKiriaty
requested changes
Feb 4, 2026
apps/scouting/frontend/src/App.tsx
Outdated
| <Route path="/scout" element={<ScoutMatch />} /> | ||
| </Routes> | ||
| <> | ||
| <GeneralDataTable filters={{ "match[type]": "qualification" }} /> |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| throw new Error(`Server Error: ${errorText}`); | ||
| } | ||
|
|
||
| const data = await response.json(); |
Check warning
Code scanning / ESLint
Disallow assigning a value with type `any` to variables and properties Warning
| } | ||
|
|
||
| const data = await response.json(); | ||
| return data.calculatedFuel as TeamNumberAndFuelData; |
Check warning
Code scanning / ESLint
Disallow type assertions that narrow a type Warning
| } | ||
|
|
||
| const data = await response.json(); | ||
| return data.calculatedFuel as TeamNumberAndFuelData; |
Check warning
Code scanning / ESLint
Disallow member access on a value with type `any` Warning
YoniKiriaty
requested changes
Feb 5, 2026
apps/scouting/frontend/src/scouter/components/GeneralDataTable.tsx
Outdated
Show resolved
Hide resolved
YoniKiriaty
approved these changes
Feb 5, 2026
apps/scouting/frontend/src/scouter/components/GeneralDataTable.tsx
Outdated
Show resolved
Hide resolved
yoavs8
approved these changes
Feb 5, 2026
apps/scouting/frontend/src/scouter/components/GeneralDataTable.tsx
Outdated
Show resolved
Hide resolved
| import { generalCalculateFuel } from "../fuel/fuel-general"; | ||
| import { StatusCodes } from "http-status-codes"; | ||
|
|
||
| import type { BPS, FuelObject, GeneralFuelData } from "@repo/scouting_types"; |
Check warning
Code scanning / ESLint
Disallow unused variables Warning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
did some backend for the data, and a table to display it. still not sure the table works, will check after we'll have db and shyte.