chore: ignore npm tooling artifacts in .gitignore#118
Open
dfcoffin wants to merge 1 commit into
Open
Conversation
This was referenced May 20, 2026
dfcoffin
added a commit
that referenced
this pull request
May 21, 2026
Replace ResponseEntity<StreamingResponseBody> with ResponseEntity<byte[]> across the 9 controllers added by #116 (26 endpoints total), and drop the corresponding asyncDispatch/MvcResult/request().asyncStarted() plumbing from 30 MockMvc test methods. Root cause of the flake: StreamingResponseBody worker threads raced with the test thread on MockHttpServletResponse's LinkedCaseInsensitiveMap when Spring Security's OnCommittedResponseWrapper triggered HeaderWriterFilter.writeHeaders -> setHeader from the worker thread. Surfaced by PR #118 CI as MeterReadingControllerTest .shouldReturn200WhenExists ConcurrentModificationException. The existing StreamingResponseBody pattern was fake streaming: JAXB marshalled the full payload to byte[] before the worker thread ran, so no real streaming benefit is lost. ESPI Sandbox response sizes don't warrant streaming; production utility implementations of /Subscription/* and /Batch/Bulk/* that need true streaming should use StAX XMLStreamWriter + a JPA cursor (per issue #119 plan). Verified: 90 tests, 0 failures, 0 errors across 3 consecutive clean runs (mvn test -pl openespi-datacustodian). Refs #119 (Phase 1) Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
Contributor
Author
|
Closing to retrigger CI now that the #120 de-stream fix has landed on main. Reopening immediately. |
Contributor
Author
|
Reopened. Latest CI run should be unaffected by the MeterReadingControllerTest CME flake that #120 fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
node_modules/,package.json, andpackage-lock.jsonto.gitignore.These artifacts appear when running npm-based developer tooling locally (schema
generators, linters, JSON schema previewers, etc.) and aren’t part of this
project’s Maven-based build.
Rationale
Without these patterns in
.gitignore, any contributor who runs annpm-based script in the repo root has to manually exclude the resulting artifacts from every commit, or risks accidentally including a multi-megabytenode_modules/directory in a PR. Adding the patterns once eliminates that friction and prevents the most common accidental-commit failure mode for npm tooling.Scope
Three new entries in
.gitignoreonly. No build configuration changes, nobehavioral changes, no impact on tracked files (none of these paths are
currently tracked in the repo).
Test plan
.gitignoreparses correctlynpm installproducesnode_modules/that does not appear ingit status.