fix(#171): re-enable CustodianHomeController so post-login /custodian/home doesn't 401#172
Merged
Merged
Conversation
…/home doesn't 401 The custodian login flow (C2a) redirects to /custodian/home on success (CustomerLoginSecurityConfiguration DEFAULT_SUCCESS_URL), but CustodianHomeController had its @controller annotation commented out ("UI not needed in resource server"). So /custodian/home had no handler -> 404 -> re-dispatched to /error -> evaluated by the resource-server filter chain as anonymous -> 401. Re-enable @controller; the view template templates/custodian/home.html exists. Surfaced during local sandbox bring-up (admin/admin login -> 401). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #171.
Custodian login (admin/admin, dev) succeeds but the post-login redirect to /custodian/home returned 401. Root cause: CustodianHomeController's @controller annotation was commented out, so /custodian/home had no handler -> 404 -> re-dispatched to /error -> the resource-server filter chain evaluated it anonymously -> 401. Re-enabled @controller; the templates/custodian/home.html view already exists.
The C2a login work set the form-login DEFAULT_SUCCESS_URL to /custodian/home but the landing controller was left disabled — this reconciles them. One-line change plus an explanatory comment. Surfaced during the local sandbox bring-up.
🤖 Generated with Claude Code