Feature/swift/model/model_design#3
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
unity側に画面を遷移した瞬間に表示されているべきタスクはどれなのかみたいな情報が欲しいかもです。
var currentTask: Int
みたいな。Intの理由は配列のインデックスを表したいから。
なくてもcurrentHPが0ではない最初のタスクを表示するなどで実装はできそうだが、編集するときなど、最後に表示していたTaskがどれなのかを記憶できたほうが拡張性もありそうだと思いました。
Member
Author
There was a problem hiding this comment.
配列の添え字をGoalに持たせる形で着地しました。
piddy-shz
reviewed
Sep 5, 2023
feat: Added AppData.swift which contains data about tags and statuses
KinjiKawaguchi
force-pushed
the
feature/swift/model/model_design
branch
from
f69ed75 to
eddd091
Compare
| let id: Int | ||
| var name: String | ||
| var color: String //16進数で表す？要検討 | ||
| var color: [Double] // [R, G, B] |
Contributor
There was a problem hiding this comment.
float型があるならfloatでお願いできますか？
swiftの都合でdoubleならこっちで合わせます。
Member
Author
There was a problem hiding this comment.
や、特に意図はなかったので、Float型に変更します。
Member
Author
|
Review結果がよく見えればLGTM（Looks good to me)をコメントしといてください。 |
Contributor
|
LGTM😆 |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@piddy-shz @KikyoNanakusa
swift側でのモデルの構造を作成しました。
それぞれの構造の妥当性（これ必要？・これなくて大丈夫？この型はこれでいいんじゃない？）を評価してください。
また、随所にコメントで議論の余地がある部分を記述してあるので、返答をお願いします。