Merged
Conversation
Contributor
|
Caution Review failedThe pull request is closed. WalkthroughIntroduces a new certification module (entity, service, DTOs, queries, controller) while removing the legacy challengecert module. Refactors challenge dates from LocalDateTime to LocalDate across entities, DTOs, queries, and repos. Adds global ChallengeClient with an adapter. Consolidates controller authentication at class level. Adds a fake auth tool. Changes
Sequence Diagram(s)sequenceDiagram
actor User
participant Controller as ChallengeCertificationController
participant Service as ChallengeCertificationService
participant Helper as CertificationClientHelper
participant Query as ChallengeCertificationQuery
participant Repo as ChallengeCertificationRepository
participant File as FileManager
User->>Controller: POST /personal/{challengeId}
Controller->>Service: certificatePersonalChallenge(cmd)
Service->>Query: checkAlreadyPersonalCert(...)
Service->>Helper: getPersonalSnapshot(challengeId, memberId, date)
Service->>Helper: getMemberSnapshot(memberId)
Service->>Repo: save(ChallengeCertification)
Service->>Helper: processCertSideEffect(imageUrl)
Service-->>Controller: void
Controller-->>User: 204 NoContent
User->>Controller: POST /team/{groupId}
Controller->>Service: certificateTeamChallenge(cmd)
Service->>Helper: getChallengeGroupDto(groupId, memberId)
Service->>Query: checkAlreadyTeamCert(challengeId, date, memberId)
Service->>Helper: getTeamSnapshot(challengeId, groupCode)
Service->>Helper: getMemberSnapshot(memberId)
Service->>Repo: save(ChallengeCertification)
Service->>Helper: processCertSideEffect(imageUrl)
Service-->>Controller: void
Controller-->>User: 204 NoContent
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested labels
Poem
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
Merged
This was referenced Aug 13, 2025
Merged
This was referenced Aug 18, 2025
Merged
This was referenced Oct 26, 2025
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣ 연관된 이슈
📝 작업 내용
📷 스크린샷
💬 리뷰 요구사항(선택)
📌 PR 진행 시 참고사항
P1: 꼭 반영해 주세요 (Request Changes) – 이슈나 취약점 관련P2: 반영을 고려해 주세요 (Comment) – 개선 의견P3: 단순 제안 (Chore)Summary by CodeRabbit