Region 12850 (Lumbridge castle) missing content #706
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
advnau
reviewed
Jun 6, 2025
advnau
left a comment
advnau
left a comment
There was a problem hiding this comment.
Cool stuff. I left some feedback on some formatting things that stand out to me. Also wanting to check on the respawn rate you have for bronze pick.
GregHib
requested changes
Jun 8, 2025
game/src/main/kotlin/content/area/misthalin/lumbridge/Victoria.kts
Outdated
Show resolved
Hide resolved
game/src/main/kotlin/content/entity/npc/combat/melee/Lumbmen.kts
Outdated
Show resolved
Hide resolved
game/src/main/kotlin/content/entity/npc/combat/melee/Lumbmen.kts
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Fixed things (not started imp) |
GregHib
approved these changes
Jun 8, 2025
Owner
|
Looking good, thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, this is my first ever pull request and wanted to add some content that was missing and two fixes for goblin sound and bronze pickaxe spawn. Any feedback and change request will be more than welcome!