Skip to content

Conversation

@GregHib
Copy link
Owner

@GregHib GregHib commented Jun 26, 2025

They were the wrong way around, although used correctly.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 26, 2025

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@codecov
Copy link

codecov bot commented Jun 26, 2025

Codecov Report

Attention: Patch coverage is 45.83333% with 13 lines in your changes missing coverage. Please review.

Project coverage is 35.42%. Comparing base (3a85bf6) to head (e265c9e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...dps/network/login/protocol/visual/PlayerVisuals.kt 0.00% 6 Missing ⚠️
...ld/gregs/voidps/network/login/protocol/Encoders.kt 0.00% 2 Missing ⚠️
...l/visual/encode/player/TemporaryMoveTypeEncoder.kt 0.00% 2 Missing ⚠️
.../gregs/voidps/engine/entity/character/Character.kt 0.00% 1 Missing ⚠️
...idps/engine/entity/character/mode/move/Movement.kt 50.00% 0 Missing and 1 partial ⚠️
...otocol/visual/encode/player/MovementTypeEncoder.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
...gs/voidps/engine/entity/character/move/Teleport.kt 70.58% <100.00%> (ø)
...ps/engine/entity/character/player/PlayerVisuals.kt 18.42% <100.00%> (ø)
...me/src/main/kotlin/content/entity/player/Login.kts 80.00% <100.00%> (ø)
...c/main/kotlin/content/social/assist/AssistArea.kts 66.66% <100.00%> (ø)
.../gregs/voidps/engine/entity/character/Character.kt 12.30% <0.00%> (ø)
...idps/engine/entity/character/mode/move/Movement.kt 58.10% <50.00%> (ø)
...otocol/visual/encode/player/MovementTypeEncoder.kt 0.00% <0.00%> (ø)
...ld/gregs/voidps/network/login/protocol/Encoders.kt 0.00% <0.00%> (ø)
...l/visual/encode/player/TemporaryMoveTypeEncoder.kt 0.00% <0.00%> (ø)
...dps/network/login/protocol/visual/PlayerVisuals.kt 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

@@            Coverage Diff            @@
##               main     #729   +/-   ##
=========================================
  Coverage     35.41%   35.42%           
+ Complexity     5175     5172    -3     
=========================================
  Files          1416     1415    -1     
  Lines         54562    54557    -5     
  Branches      10678    10678           
=========================================
  Hits          19325    19325           
+ Misses        31544    31537    -7     
- Partials       3693     3695    +2     
Components Coverage Δ
Content 31.68% <100.00%> (ø)
Engine 38.57% <81.81%> (ø)
Network 71.55% <0.00%> (+0.12%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@GregHib GregHib merged commit 4810669 into main Jun 26, 2025
5 checks passed
@GregHib GregHib deleted the move-type-flip branch June 26, 2025 14:49
Ilwyd pushed a commit to Ilwyd/void that referenced this pull request Jun 29, 2025
* Switch moveType and tempMoveType as the naming was the wrong way around

* Switch moveType and tempMoveType helpers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants