Skip to content

Conversation

@GregHib
Copy link
Owner

@GregHib GregHib commented Jul 11, 2025

No description provided.

@GregHib GregHib force-pushed the god_wars_dungeon branch from c6e4c51 to d31a32b Compare July 28, 2025 11:05
@GregHib GregHib marked this pull request as ready for review July 28, 2025 11:05
@github-actions
Copy link
Contributor

github-actions bot commented Jul 28, 2025

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@codecov
Copy link

codecov bot commented Jul 28, 2025

Codecov Report

❌ Patch coverage is 38.86010% with 472 lines in your changes missing coverage. Please review.
✅ Project coverage is 35.72%. Comparing base (9efca62) to head (86a0dda).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...content/area/troll_country/trollheim/Trollheim.kts 5.98% 110 Missing ⚠️
...t/area/troll_country/god_wars_dungeon/SirGerry.kts 22.41% 41 Missing and 4 partials ⚠️
...roll_country/god_wars_dungeon/armadyl/KreeArra.kts 35.84% 30 Missing and 4 partials ⚠️
...ountry/god_wars_dungeon/zamorak/KrilTsutsaroth.kts 35.41% 27 Missing and 4 partials ⚠️
...ountry/god_wars_dungeon/bandos/GeneralGraardor.kts 38.29% 27 Missing and 2 partials ⚠️
...ry/god_wars_dungeon/saradomin/CommanderZilyana.kts 41.30% 23 Missing and 4 partials ⚠️
...oll_country/god_wars_dungeon/GodwarsAggression.kts 53.57% 13 Missing and 13 partials ⚠️
...country/god_wars_dungeon/zamorak/GodwarsAltars.kts 4.16% 23 Missing ⚠️
...a/troll_country/god_wars_dungeon/ArmadylPillar.kts 50.00% 21 Missing and 1 partial ⚠️
...ea/troll_country/god_wars_dungeon/ThrowerTroll.kts 0.00% 11 Missing ⚠️
... and 29 more
Additional details and impacted files
Files with missing lines Coverage Δ
...n/world/gregs/voidps/engine/data/AccountManager.kt 69.13% <100.00%> (ø)
.../gregs/voidps/engine/entity/character/Character.kt 10.00% <ø> (-2.31%) ⬇️
...s/engine/entity/character/mode/move/AreaEntered.kt 35.00% <100.00%> (+3.42%) ⬆️
...ps/engine/entity/character/mode/move/AreaExited.kt 33.33% <100.00%> (+1.75%) ⬆️
...ps/engine/entity/character/mode/move/PathFinder.kt 60.37% <100.00%> (+1.88%) ⬆️
...gs/voidps/engine/entity/character/player/Player.kt 91.83% <100.00%> (+0.34%) ⬆️
...a/troll_country/god_wars_dungeon/ZamorakBridge.kts 100.00% <100.00%> (ø)
game/src/main/kotlin/content/entity/Movement.kts 65.62% <100.00%> (ø)
.../src/main/kotlin/content/entity/death/NPCDeath.kts 66.14% <100.00%> (ø)
.../main/kotlin/content/entity/obj/ObjectTeleports.kt 79.54% <100.00%> (ø)
... and 41 more

... and 7 files with indirect coverage changes

@@             Coverage Diff              @@
##               main     #733      +/-   ##
============================================
+ Coverage     35.67%   35.72%   +0.04%     
- Complexity     5217     5271      +54     
============================================
  Files          1421     1438      +17     
  Lines         54882    55578     +696     
  Branches      10729    10900     +171     
============================================
+ Hits          19580    19856     +276     
- Misses        31571    31936     +365     
- Partials       3731     3786      +55     
Components Coverage Δ
Content 32.20% <39.57%> (+0.17%) ⬆️
Engine 38.48% <31.34%> (-0.08%) ⬇️
Network 71.55% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@GregHib GregHib merged commit fd3e1cd into main Jul 28, 2025
5 checks passed
@GregHib GregHib deleted the god_wars_dungeon branch July 28, 2025 15:37
@Hc747
Copy link

Hc747 commented Jul 28, 2025

So clean

@GregHib GregHib mentioned this pull request Jul 30, 2025
35 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants