Skip to content

Conversation

@GregHib
Copy link
Owner

@GregHib GregHib commented Oct 29, 2025

@github-actions
Copy link
Contributor

github-actions bot commented Oct 29, 2025

Qodana Community for JVM

1 new problem were found

Inspection name Severity Problems
Unused symbol 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@codecov
Copy link

codecov bot commented Oct 29, 2025

Codecov Report

❌ Patch coverage is 47.85068% with 922 lines in your changes missing coverage. Please review.
✅ Project coverage is 34.70%. Comparing base (9b7d5de) to head (4b11c1c).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...n/world/gregs/voidps/engine/entity/Approachable.kt 8.12% 147 Missing ⚠️
...tlin/world/gregs/voidps/engine/entity/Operation.kt 8.12% 147 Missing ⚠️
...kotlin/world/gregs/voidps/engine/timer/TimerApi.kt 27.77% 33 Missing and 6 partials ⚠️
...n/kotlin/world/gregs/voidps/engine/entity/Spawn.kt 17.94% 26 Missing and 6 partials ⚠️
...gregs/voidps/engine/client/variable/VariableSet.kt 17.39% 14 Missing and 5 partials ⚠️
...ntity/character/player/skill/level/LevelChanged.kt 13.63% 14 Missing and 5 partials ⚠️
...otlin/content/skill/constitution/drink/Overload.kt 26.92% 16 Missing and 3 partials ⚠️
...c/main/kotlin/content/skill/prayer/active/Leech.kt 18.18% 17 Missing and 1 partial ⚠️
...oidps/engine/data/definition/DefinitionsDecoder.kt 0.00% 16 Missing ⚠️
.../voidps/engine/entity/character/mode/move/Moved.kt 13.33% 12 Missing and 1 partial ⚠️
... and 119 more
Additional details and impacted files
Files with missing lines Coverage Δ
...n/world/gregs/voidps/engine/data/AccountManager.kt 72.00% <100.00%> (ø)
...gine/entity/character/player/skill/level/Levels.kt 91.52% <100.00%> (ø)
...regs/voidps/engine/entity/item/floor/FloorItems.kt 65.33% <100.00%> (ø)
...orld/gregs/voidps/engine/entity/obj/GameObjects.kt 63.53% <100.00%> (ø)
...tlin/content/area/asgarnia/falador/MakeoverMage.kt 6.40% <100.00%> (+1.52%) ⬆️
...t/area/asgarnia/port_sarim/BartenderRustyAnchor.kt 40.74% <100.00%> (+2.27%) ⬆️
...content/area/asgarnia/port_sarim/PortSarimGuard.kt 16.66% <100.00%> (+2.38%) ⬆️
.../kotlin/content/area/asgarnia/taverley/Bettamax.kt 100.00% <100.00%> (ø)
...lin/content/area/asgarnia/taverley/WitchesHouse.kt 100.00% <100.00%> (ø)
...kandarin/barbarian_outpost/BarbarianOutpostGate.kt 63.63% <100.00%> (ø)
... and 177 more

... and 2 files with indirect coverage changes

@@             Coverage Diff              @@
##               main     #787      +/-   ##
============================================
+ Coverage     34.57%   34.70%   +0.12%     
+ Complexity     6277     6257      -20     
============================================
  Files          1526     1522       -4     
  Lines         55998    56502     +504     
  Branches      15239    15311      +72     
============================================
+ Hits          19364    19607     +243     
- Misses        31634    31884     +250     
- Partials       5000     5011      +11     
Components Coverage Δ
Content 32.57% <63.33%> (+0.46%) ⬆️
Engine 36.27% <13.18%> (-0.91%) ⬇️
Network 60.32% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@GregHib GregHib changed the title Revert dispatchers changes for events handling v2 Revert dispatchers changes for event handling v2 Oct 29, 2025
@GregHib GregHib merged commit 23c92ff into main Oct 29, 2025
5 checks passed
@GregHib GregHib deleted the dispatchers-v2 branch October 29, 2025 19:13
Ilwyd pushed a commit to Ilwyd/void that referenced this pull request Dec 22, 2025
* Add backwards compatible wildcard lookup for closer to existing format

* Convert Spawn to new method

* Convert LevelChanged to new method

* Convert Moved to new method and removed unnecessary `to` field

* Convert VariableSet to new method

* Convert Timer to new method

* Add support for interface:component id wildcard matching

* Support transformed id lookup inside npc + objects

* Operation wip

* Add interaction helpers

* Operation fixes

* Operation fixes

* Update approachable

* Remove annotations

* Remove concept of dispatcher

* Add operate and approach wildcards

* Don't use approach and operate for now

* Tweaks

* Fixes

* Formatting

* Unit test fixes

* Remove unused imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants