Skip to content

Conversation

@GregHib
Copy link
Owner

@GregHib GregHib commented Nov 4, 2025

  • Enter/exit area
  • Open quest journal
  • Death/AfterDeath
  • ContinueDialogue/ItemDialogue
  • VariableBitAdded/Removed
  • PrayerStart/Stop
  • SongEnd
  • MaxLevelChanged
  • Experience/Blocked
  • DoorOpened

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2025

Qodana Community for JVM

3 new problems were found

Inspection name Severity Problems
Unused import directive 🔶 Warning 1
Unused receiver parameter 🔶 Warning 1
Replace empty class body ◽️ Notice 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@codecov
Copy link

codecov bot commented Nov 4, 2025

Codecov Report

❌ Patch coverage is 46.39321% with 379 lines in your changes missing coverage. Please review.
✅ Project coverage is 35.18%. Comparing base (d8844d9) to head (a77defd).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...n/kotlin/content/area/misthalin/varrock/Delrith.kt 2.38% 41 Missing ⚠️
...dps/engine/entity/character/player/skill/Skills.kt 25.00% 21 Missing and 6 partials ⚠️
...orld/gregs/voidps/engine/entity/character/Death.kt 0.00% 20 Missing ⚠️
...tlin/content/entity/player/modal/book/BookPages.kt 29.62% 19 Missing ⚠️
.../voidps/engine/entity/character/mode/move/Moved.kt 12.50% 10 Missing and 4 partials ⚠️
...me/src/main/kotlin/content/entity/combat/Combat.kt 64.10% 6 Missing and 8 partials ⚠️
...lin/content/quest/member/plague_city/PlagueCity.kt 0.00% 14 Missing ⚠️
...ntent/quest/free/cooks_assistant/CooksAssistant.kt 0.00% 12 Missing ⚠️
...regs/voidps/engine/client/ui/dialogue/Dialogues.kt 0.00% 10 Missing ⚠️
...n/content/quest/member/monkey_madness/Greegrees.kt 16.66% 10 Missing ⚠️
... and 60 more
Additional details and impacted files
Files with missing lines Coverage Δ
.../world/gregs/voidps/engine/client/ui/Interfaces.kt 61.70% <ø> (+0.16%) ⬆️
...n/world/gregs/voidps/engine/data/AccountManager.kt 72.97% <100.00%> (ø)
...n/world/gregs/voidps/engine/entity/Approachable.kt 0.00% <ø> (ø)
...kotlin/world/gregs/voidps/engine/entity/Despawn.kt 15.38% <ø> (ø)
...tlin/world/gregs/voidps/engine/entity/Operation.kt 0.00% <ø> (ø)
...n/kotlin/world/gregs/voidps/engine/entity/Spawn.kt 17.94% <ø> (ø)
...gs/voidps/engine/entity/character/player/Player.kt 91.66% <ø> (-0.18%) ⬇️
...ne/entity/character/player/skill/exp/Experience.kt 87.87% <100.00%> (-0.36%) ⬇️
...gine/entity/character/player/skill/level/Levels.kt 91.52% <100.00%> (ø)
...world/gregs/voidps/engine/event/EventDispatcher.kt 13.04% <ø> (-6.19%) ⬇️
... and 92 more

... and 1 file with indirect coverage changes

@@             Coverage Diff              @@
##               main     #793      +/-   ##
============================================
+ Coverage     34.97%   35.18%   +0.21%     
- Complexity     6377     6413      +36     
============================================
  Files          1518     1493      -25     
  Lines         56564    56405     -159     
  Branches      14749    14598     -151     
============================================
+ Hits          19785    19848      +63     
+ Misses        31790    31621     -169     
+ Partials       4989     4936      -53     
Components Coverage Δ
Content 33.28% <53.46%> (+0.30%) ⬆️
Engine 36.62% <22.01%> (+0.13%) ⬆️
Network 60.32% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@GregHib GregHib merged commit bd6bbbf into main Nov 4, 2025
5 checks passed
@GregHib GregHib deleted the misc-handlers branch November 4, 2025 18:54
Ilwyd pushed a commit to Ilwyd/void that referenced this pull request Dec 22, 2025
* Migrate enter and exit area's

* Migrate open quest journals

* Remove CombatInteraction, Interaction and InteractionType

* Remove SuspendableEvent.kt

* Remove CloseInterface.kt.kt

* Migrate Death and remove AfterDeath.kt

* Migrate VariableBitAdded/Removed, PrayerStart/Stop and BotStart

* Migrate ReloadRegion, RegionLoad, RegionReload and SettingsReload

* Migrate SongEndEvent.kt, remove SongEndHandler.kt

* Migrate ContinueDialogue/ItemDialogue

* Migrate MaxLevelChanged, Experience, BlockedExperience and DoorOpened

* Make sure wildcards are ordered
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants