Skip to content

Conversation

@GregHib
Copy link
Owner

@GregHib GregHib commented Nov 24, 2025

  • Fix examines on some interfaces
  • Update readme with install guide
  • Fix stacking items with single charges (like ring of duelling)
  • Fix bank chests
  • Fix equipment bonus side options getting stuck

@github-actions
Copy link
Contributor

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

❌ Patch coverage is 65.00000% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.18%. Comparing base (9c82412) to head (12a8a54).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
game/src/main/kotlin/content/entity/npc/Banker.kt 0.00% 3 Missing ⚠️
...tlin/world/gregs/voidps/engine/entity/item/Item.kt 50.00% 0 Missing and 1 partial ⚠️
game/src/main/kotlin/content/entity/Examines.kt 91.66% 1 Missing ⚠️
...main/kotlin/content/entity/player/bank/BankOpen.kt 0.00% 1 Missing ⚠️
...in/content/entity/player/equip/EquipmentBonuses.kt 50.00% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
...tlin/world/gregs/voidps/engine/entity/item/Item.kt 60.00% <50.00%> (+1.66%) ⬆️
game/src/main/kotlin/content/entity/Examines.kt 54.28% <91.66%> (+22.28%) ⬆️
...main/kotlin/content/entity/player/bank/BankOpen.kt 43.39% <0.00%> (-0.84%) ⬇️
...in/content/entity/player/equip/EquipmentBonuses.kt 24.10% <50.00%> (-0.22%) ⬇️
game/src/main/kotlin/content/entity/npc/Banker.kt 26.82% <0.00%> (-1.38%) ⬇️

... and 1 file with indirect coverage changes

@@            Coverage Diff            @@
##               main     #801   +/-   ##
=========================================
  Coverage     37.17%   37.18%           
+ Complexity     7058     7056    -2     
=========================================
  Files          1455     1455           
  Lines         55914    55929   +15     
  Branches      14007    14007           
=========================================
+ Hits          20788    20799   +11     
- Misses        30491    30494    +3     
- Partials       4635     4636    +1     
Components Coverage Δ
Content 34.06% <66.66%> (+0.01%) ⬆️
Engine 44.86% <50.00%> (+<0.01%) ⬆️
Network 60.32% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@GregHib GregHib merged commit 30a490a into main Nov 24, 2025
5 checks passed
@GregHib GregHib deleted the qol-fixes branch November 24, 2025 21:09
Ilwyd pushed a commit to Ilwyd/void that referenced this pull request Dec 22, 2025
* Fix interface examines by not using wildcard

* Update read-me with installation guide

* Fix stacking single charge items

* Fix bank chests

* Fix bank booths

* Fix bank inventory options getting stuck
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants