-
Notifications
You must be signed in to change notification settings - Fork 52
More spawns, fixes and preserve history #810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
GregHib
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small tweaks
game/src/main/kotlin/content/area/misthalin/lumbridge/CowFieldSignpost.kt
Outdated
Show resolved
Hide resolved
game/src/main/kotlin/content/area/misthalin/lumbridge/PlayerDeathSignpost.kt
Outdated
Show resolved
Hide resolved
| import world.gregs.voidps.engine.Script | ||
|
|
||
| class PlayerDeathSignpost : Script { | ||
| var playerDeathsToday: Int = 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's probably worth considering if these values should be saved (if so how) as they'll reset anytime the server restarts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot to add source to this but in runescape they reset after 24h, I don't know if in void there is 24h reset. But this is actually a good suggestion if we save them, because you can see then how many times players have died or killed cows in whole server.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://runescape.fandom.com/wiki/Signpost
"The information signs show various statistics when read. They reset when the server is rebooted."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay yeah there's no 24h reset (it could be added) but if it's just per server reboot then this is good enough for me
game/src/main/kotlin/content/entity/npc/combat/melee/LumbridgeGuardsmanAttackble.kt
Outdated
Show resolved
Hide resolved
|
Fixed, thanks for the feedback as always! |
* Added lumbridge guard attackable version * Added giant rat spawn close to lumbridge castle * deleted master farmer spawn (was added later in rs3 in lumbridge) * Fixed tool leprechaun and fayeth spawn closer to tree patch * Fixed ram npc death animation * Fixed giant rat and rat death animations * Added clan cup plaque to preserve history * Fixed black wool and ball of black wool not tradeable * Added two statistic signposts
Added Lumbridge guard attackable version.
Added giant rats close to lumbridge castle.
Fixed tool leprechaun and frayeth spawn closer to tree patch.
Removed master farmer spawn in lumbridge.
Fixed ram, giant rat and rat death animation ticks.
Added clan cup plaque to preserve history.
Fixed black wool and ball of black wool to not tradeable
Added two lumbridge statistic signposts