Convert primary entity lists to static objects

[GregHib]

#836

• Converts Players, NPCs, GameObjects and FloorItems (along with some misc like Collisions)
• Also converts their dependencies (NPCDefinitions, ObjectDefinitions, ItemDefinitions etc...)
• Remove need for specifying in script constructors e.g. val players: Players
• Introduce clearer api for access and lookups Players.at(tile), NPCs.first(zone, "npc_id")

[github-actions]

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

• Or via our issue tracker: https://jb.gg/qodana-issue
• Or share your feedback: https://jb.gg/qodana-discussions

[codecov]

Codecov Report

❌ Patch coverage is 42.45754% with 576 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.17%. Comparing base (46abc83) to head (bc24f6e).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
game/src/main/kotlin/Main.kt	0.00%	33 Missing ⚠️
...in/content/entity/player/command/PlayerCommands.kt	0.00%	24 Missing ⚠️
...orld/gregs/voidps/engine/entity/obj/GameObjects.kt	52.50%	19 Missing ⚠️
...area/misthalin/lumbridge/church/LumbridgeChurch.kt	5.88%	16 Missing ⚠️
.../kotlin/world/gregs/voidps/engine/EngineModules.kt	0.00%	15 Missing ⚠️
...ld/gregs/voidps/engine/map/collision/Collisions.kt	31.57%	13 Missing ⚠️
...n/kotlin/content/area/misthalin/varrock/Delrith.kt	13.33%	13 Missing ⚠️
...ntent/entity/player/command/NPCUpdatingCommands.kt	0.00%	12 Missing ⚠️
...lin/content/skill/magic/jewellery/GamesNecklace.kt	8.33%	11 Missing ⚠️
...content/area/misthalin/barbarian_village/Gudrun.kt	9.09%	10 Missing ⚠️
... and 173 more

Additional details and impacted files

Files with missing lines	Coverage Δ
...cache/definition/decoder/QuickChatOptionDecoder.kt	0.00% <ø> (ø)
...orld/gregs/voidps/engine/client/ui/InterfaceApi.kt	73.03% <ø> (ø)
...voidps/engine/client/update/CharacterUpdateTask.kt	100.00% <100.00%> (ø)
...ps/engine/client/update/player/PlayerUpdateTask.kt	59.66% <100.00%> (-0.17%)	⬇️
...gs/voidps/engine/data/definition/NPCDefinitions.kt	60.00% <100.00%> (ø)
...voidps/engine/data/definition/ObjectDefinitions.kt	63.41% <100.00%> (+2.88%)	⬆️
...ntity/character/mode/move/target/TargetStrategy.kt	64.28% <100.00%> (ø)
...s/voidps/engine/entity/character/player/Players.kt	52.38% <100.00%> (+3.54%)	⬆️
...tlin/world/gregs/voidps/engine/entity/item/Item.kt	60.00% <100.00%> (ø)
...gregs/voidps/engine/entity/item/floor/FloorItem.kt	86.36% <100.00%> (ø)
... and 233 more

... and 32 files with indirect coverage changes

@@             Coverage Diff              @@
##               main     #837      +/-   ##
============================================
- Coverage     37.32%   37.17%   -0.16%     
- Complexity     7149     7246      +97     
============================================
  Files          1491     1492       +1     
  Lines         59078    58869     -209     
  Branches      14841    14841              
============================================
- Hits          22053    21882     -171     
+ Misses        32076    32038      -38     
  Partials       4949     4949              

Components	Coverage Δ
Content	34.37% <43.66%> (-0.30%)	⬇️
Engine	42.88% <39.59%> (+0.11%)	⬆️
Network	60.93% <ø> (ø)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.