Skip to content

Add better cutscene/instance handling and demon slayer fixes#906

Merged
GregHib merged 12 commits intomainfrom
cutscene-fixes
Mar 6, 2026
Merged

Add better cutscene/instance handling and demon slayer fixes#906
GregHib merged 12 commits intomainfrom
cutscene-fixes

Conversation

@GregHib
Copy link
Owner

@GregHib GregHib commented Mar 6, 2026

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2026

Qodana for JVM

1 new problem were found

Inspection name Severity Problems
Unused symbol 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@GregHib GregHib merged commit 38bd9da into main Mar 6, 2026
3 checks passed
@GregHib GregHib deleted the cutscene-fixes branch March 6, 2026 19:07
@codecov
Copy link

codecov bot commented Mar 6, 2026

Codecov Report

❌ Patch coverage is 69.44444% with 33 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.49%. Comparing base (9c51823) to head (86b6593).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...n/kotlin/content/area/misthalin/varrock/Delrith.kt 55.10% 11 Missing and 11 partials ⚠️
...oidps/engine/entity/character/CharacterIndexMap.kt 80.00% 1 Missing and 2 partials ⚠️
...n/kotlin/world/gregs/voidps/engine/entity/World.kt 0.00% 2 Missing ⚠️
...lin/content/quest/member/plague_city/PlagueCity.kt 0.00% 1 Missing and 1 partial ⚠️
game/src/main/kotlin/Main.kt 0.00% 1 Missing ⚠️
...kotlin/content/area/misthalin/varrock/GypsyAris.kt 66.66% 1 Missing ⚠️
...rc/main/kotlin/content/entity/death/PlayerDeath.kt 0.00% 0 Missing and 1 partial ⚠️
...s/src/main/kotlin/world/gregs/voidps/type/Delta.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
...d/gregs/voidps/engine/entity/character/npc/NPCs.kt 56.55% <ø> (+0.91%) ⬆️
...s/voidps/engine/entity/character/player/Players.kt 53.65% <ø> (+1.27%) ⬆️
...lin/world/gregs/voidps/engine/queue/ActionQueue.kt 57.60% <100.00%> (+0.46%) ⬆️
.../kotlin/content/area/kandarin/ardougne/Ardougne.kt 43.07% <100.00%> (ø)
...in/kotlin/content/area/kandarin/ardougne/Edmond.kt 57.59% <100.00%> (+0.27%) ⬆️
...tent/area/kandarin/ardougne/west_ardougne/Elena.kt 39.28% <100.00%> (ø)
game/src/main/kotlin/content/quest/Cutscene.kt 88.75% <100.00%> (+7.92%) ⬆️
...me/src/main/kotlin/content/quest/InstanceLogout.kt 100.00% <100.00%> (ø)
game/src/main/kotlin/Main.kt 0.00% <0.00%> (ø)
...kotlin/content/area/misthalin/varrock/GypsyAris.kt 49.35% <66.66%> (+47.63%) ⬆️
... and 6 more

... and 15 files with indirect coverage changes

@@             Coverage Diff              @@
##               main     #906      +/-   ##
============================================
+ Coverage     37.75%   38.49%   +0.74%     
- Complexity     7590     7677      +87     
============================================
  Files          1560     1562       +2     
  Lines         61795    61822      +27     
  Branches      15681    15687       +6     
============================================
+ Hits          23330    23798     +468     
+ Misses        33248    32717     -531     
- Partials       5217     5307      +90     
Components Coverage Δ
Content 36.29% <68.23%> (+1.17%) ⬆️
Engine 44.66% <77.27%> (-0.08%) ⬇️
Network 60.85% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant