Conversation
Contributor
Qodana for JVM5 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
HarleyGilpin
added a commit
to HarleyGilpin/void
that referenced
this pull request
May 17, 2026
PR GregHib#980 deleted softQueue; replace the three pet/kitten call sites with weakQueue (closest semantic match: easily-preempted fire-and- forget) and drop the leftover `player.` prefixes inside the lambdas since Player is now the lambda receiver. While in KittenInteract, fix two bugs in chaseVermin: - The cat used to chase pirates because "pirate" contains the substring "rat". Predicate now matches the npc string id with a `_` word boundary (rat / *_rat / rat_* / *_rat_*). - The cat never caught anything because the 5-tick callback always fired the failure message. Roll a 33% catch chance up front; on success despawn the rat and message the win. Adjacency guard covers the case where the rat wanders before the kitten arrives.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New action queue system which more accurate emulates the original. Closes #976
Remove all soft queues (these are only used in osrs)
Introduce long queues instead of LogoutBehaviour
Remove all types of npc queue except for normal
Combine delay, dialogueSuspension and suspension into one
Add walk trigger system
Add separate weak queue
Add engine queue support
Add action linked list to replicate drop last queue behaviour (e.g. dds spec kills 1 tick faster than single hits)
Fix toolchains for running tools without jdk 21
Fix book pages not clearing anim on close
Fix modern teleport land animation
Fix ape atoll agility course animation not resetting
Fix not being able to mine whilst in combat