Changed shouldCheckWeakPower to work around bug#1331
Merged
LAGIdiot merged 2 commits intoGregTechCE:masterfrom Dec 14, 2020
solidDoWant:master
Merged
Changed shouldCheckWeakPower to work around bug#1331LAGIdiot merged 2 commits intoGregTechCE:masterfrom solidDoWant:master
LAGIdiot merged 2 commits intoGregTechCE:masterfrom
solidDoWant:master
Conversation
Member
|
Thank you for spotting this issue and fixing it. |
LAGIdiot
approved these changes
Dec 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
A vanilla bug prevents getWeakPower from being called. This results in machines and covers being unable to set redstone outputs.
From line 3546 of World::getRedstonePower:
As the above image shows, the ternary statement is reversed.
How solved:
I've changed the two implementations of shouldCheckWeakPower to return 'false' instead of 'true', along with an inline explanation of why that's the case.
Outcome:
Fixes: Machines and covers now have the ability to output redstone.
Possible compatibility issue:
No machines or covers currently exist that use this. The change should only affect addons.