Fix the Fuelable TOP provider to do its translation on the client#1511
Merged
LAGIdiot merged 2 commits intoGregTechCE:masterfrom Mar 8, 2021
Merged
Fix the Fuelable TOP provider to do its translation on the client#1511LAGIdiot merged 2 commits intoGregTechCE:masterfrom
LAGIdiot merged 2 commits intoGregTechCE:masterfrom
Conversation
warjort
changed the title
LAGIdiot
approved these changes
Mar 7, 2021
Member
LAGIdiot
left a comment
LAGIdiot
left a comment
There was a problem hiding this comment.
Thanks for fixing this issue. It did not occurred to me that this could happened but at least we know for future reference.
LAGIdiot
added
rsr: revision
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
The new Fuelable TOP provider is erroring in dedicated server mode.
How solved:
The error is due to it trying to do the translation on the server. This is now done on the client.
Outcome:
Closes #1508
Additional info:
The TOP progress bar does not allow its "suffix" to have translatable text inside it.
So I have moved the extra info about burn time and minimum fuel into a seperate text component.
This means that information now appears further to the right.
Possible compatibility issue:
The getFuelName() for the Fluid and Item fuel info have been changed to use the "unlocalizedName", so the server can pass it to the client for translation.
SInce this code is new, it is unlikely something else will be using this.
But even if something was using it, it would also need this change to be able to translate the name on the client.