Adjust Biome Name tooltip to use getter#1518
Merged
LAGIdiot merged 1 commit intoGregTechCE:masterfrom Mar 8, 2021
Merged
Conversation
LAGIdiot
approved these changes
Mar 8, 2021
Member
LAGIdiot
left a comment
LAGIdiot
left a comment
There was a problem hiding this comment.
Thanks for fixing this issue.
LAGIdiot
added
rsr: revision
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
This PR brings the important fix of changing the Biome Name tooltip to use the biome name getter out of PR #1506. This is done so that it can be merged without having the finalize the issues in that PR and reviewing the entire PR.
How solved:
In future MCP mappings, the
biomeNamefield changed to private, which caused some players to get access errors when viewing the tooltip on the ore spawn page. This PR simply switches from using the field to using the getter.Outcome:
Fixes crash when viewing tooltip on JEI Ore page.
Possible compatibility issue:
There should be none