Add more Run Config + Option to use old Jar Naming Format #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
As of be4ede3, this also now makes the api jar task run on |
serenibyss
reviewed
Jun 18, 2023
Member
serenibyss
left a comment
serenibyss
left a comment
There was a problem hiding this comment.
Minor suggestion, otherwise looks good
serenibyss
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some notes:
Modifying the run configs in
addon.gradlewould just addon, and not modify existing run configsEditing the jar naming format in
addon.gradledoes not work, as it is run before the version is set, meaning that it is overrided back to just version.This can be useful for old mods that want to resume their old format, and for mods that support lots of Minecraft versions.