Merged
Conversation
…Draws with it, how tragic! This can't be! The Strange and Obscure events of the gtceu mod jar legends
screret
previously requested changes
Dec 1, 2024
src/main/java/com/gregtechceu/gtceu/common/data/machines/GCYMMachines.java
Outdated
Show resolved
Hide resolved
YoungOnionMC
approved these changes
Dec 3, 2024
Contributor
|
|
Contributor
|
O7 |
Contributor
|
where were you when compass was kil. o7 |
Contributor
|
it wasn't that bad :( |
Member
Author
|
Member
|
I was walking the dog Message pops on my phone "Compass is kil" "No" |
Contributor
|
i think there may be a typo there "Compass is kil" "Yes" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes All Compass Content and Integration in GTCEU as a whole, as part of moving away from LDLIB reliance.
Compass is used nearly as frequently as Fabric was for us, but contributed to a bunch of code that had to still be maintained, slimming this down will mean less reliance on other project libraries. Myself and Several people are in favor of this (Namely Tech, Spicy, Onion, and myself)
Implementation Details
Fully Erases compass and all related content to it
Outcome
Removes Compass
Potential Compatibility Issues
If you are the 0.1% of people using compass, you will no longer be able to use it next major update, please look into using Patchouli or Modonomicon if you need a booklet guide.
Additional Information
i was at house, eating chicken... when phone ring...
"Compass is kil"
"Yes..."