Chanced Ingredient Tests#4320
Draft
DilithiumThoride wants to merge 35 commits into
Draft
Conversation
DilithiumThoride
added
ignore changelog
# Conflicts: # src/test/java/com/gregtechceu/gtceu/api/recipe/ingredient/IntProviderFluidIngredientTest.java
github-actions
Bot
added
Tests: Passed
…in-ba-sing-se' into dt/there-are-no-chance-boosters-in-ba-sing-se # Conflicts: # src/main/java/com/gregtechceu/gtceu/api/capability/recipe/FluidRecipeCapability.java # src/main/java/com/gregtechceu/gtceu/api/capability/recipe/ItemRecipeCapability.java # src/main/java/com/gregtechceu/gtceu/api/machine/multiblock/MultiblockDisplayText.java # src/main/java/com/gregtechceu/gtceu/api/recipe/GTRecipeType.java # src/main/java/com/gregtechceu/gtceu/api/recipe/RecipeRunner.java # src/main/java/com/gregtechceu/gtceu/api/recipe/chance/logic/ChanceLogic.java # src/main/java/com/gregtechceu/gtceu/api/recipe/content/Content.java # src/main/java/com/gregtechceu/gtceu/api/recipe/content/IContentSerializer.java # src/main/java/com/gregtechceu/gtceu/common/data/GTRecipeTypes.java # src/main/java/com/gregtechceu/gtceu/integration/jade/provider/RecipeOutputProvider.java # src/main/java/com/gregtechceu/gtceu/integration/kjs/recipe/components/ContentJS.java # src/main/java/com/gregtechceu/gtceu/integration/recipeviewer/widgets/GTOreByProduct.java # src/main/java/com/gregtechceu/gtceu/integration/xei/widgets/GTOreByProductWidget.java # src/main/java/com/gregtechceu/gtceu/integration/xei/widgets/GTRecipeWidget.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Preliminary set of tests for ChanceLogic.OR in recipes.
One test currently fails (blocked by #4300 )
Two tests commented out, failure unknown.
Further tests required for further cases, including specific tests for the Assembly Line and Distillation Tower, because they use custom recipe logic; and the tests to then be replicated across AND and XOR.
Requires #4968