Add ISyncAnnotated for syncable data classes and clean up some other sync stuff#4848
Merged
Conversation
jurrejelle
requested changes
May 18, 2026
|
|
||
| ```java | ||
| class MySyncObject implements ISyncManaged { | ||
| // Any class that directly implements ISyncManaged must have the following: |
Contributor
There was a problem hiding this comment.
Do we want to split out "any ISyncManaged class should have this" and "Here's an example of how to use ISyncManaged class"?
jurrejelle
reviewed
May 18, 2026
Co-authored-by: Jurre Groenendijk <jurre@jilles.com>
jurrejelle
approved these changes
May 18, 2026
screret
reviewed
May 18, 2026
Comment on lines
+681
to
+683
| // Necessary since a RecipeCapability was removed when removing Create support, | ||
| // and for future | ||
| // removals |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds ISyncAnnotated for syncable data classes
Also cleans up some more sync related stuff
Outcome
Happy onion 🧅
How Was This Tested
Game loads with valid data, saving and reloading has correct data, client data also appears correct.