Merged
Conversation
ALongStringOfNumbers
force-pushed
the
alson-fluid-vein-jei
branch
2 times, most recently
from
3a7a3fb to
c89434b
Compare
LAGIdiot
reviewed
Oct 28, 2022
Contributor
LAGIdiot
left a comment
LAGIdiot
left a comment
There was a problem hiding this comment.
This functionality is really nice to have and it will be great addition to ore page.
It looks solid in game and tooltips are really useful. Though the amount of information feels overwhelming maybe separating then to two categories yield related and rest could help.
There is lots of duplicity in code. Some of I pointed out. And I think most could be handle by moving it to new base class for this kind of JEI information pages.
src/main/java/gregtech/integration/jei/basic/GTFluidVeinInfo.java
Outdated
Show resolved
Hide resolved
src/main/java/gregtech/integration/jei/basic/GTFluidVeinCategory.java
Outdated
Show resolved
Hide resolved
src/main/java/gregtech/integration/jei/basic/GTFluidVeinCategory.java
Outdated
Show resolved
Hide resolved
src/main/java/gregtech/integration/jei/basic/GTFluidVeinCategory.java
Outdated
Show resolved
Hide resolved
src/main/java/gregtech/integration/jei/basic/GTFluidVeinInfo.java
Outdated
Show resolved
Hide resolved
LAGIdiot
requested changes
Nov 11, 2022
Contributor
LAGIdiot
left a comment
LAGIdiot
left a comment
There was a problem hiding this comment.
As per my previous comments.
ALongStringOfNumbers
force-pushed
the
alson-fluid-vein-jei
branch
from
c89434b to
1aa5ded
Compare
ALongStringOfNumbers
force-pushed
the
alson-fluid-vein-jei
branch
from
39977bf to
ed5e6ed
Compare
LAGIdiot
requested changes
Dec 19, 2022
Contributor
LAGIdiot
left a comment
LAGIdiot
left a comment
There was a problem hiding this comment.
Good job on cleanup! I found few other places that could use some.
|
|
||
|
|
||
| public GTFluidVeinCategory(IGuiHelper guiHelper) { | ||
| super("fluid_spawn_location", |
Contributor
There was a problem hiding this comment.
fluid_spawn_location is used in different files too right?
src/main/java/gregtech/integration/jei/basic/GTFluidVeinCategory.java
Outdated
Show resolved
Hide resolved
src/main/java/gregtech/integration/jei/recipe/primitive/BasicRecipeCategory.java
Outdated
Show resolved
Hide resolved
ALongStringOfNumbers
force-pushed
the
alson-fluid-vein-jei
branch
2 times, most recently
from
fb255bc to
3d0df2a
Compare
ALongStringOfNumbers
force-pushed
the
alson-fluid-vein-jei
branch
from
2822fe2 to
e029b92
Compare
ALongStringOfNumbers
force-pushed
the
alson-fluid-vein-jei
branch
from
c64bec2 to
bb4f33b
Compare
ALongStringOfNumbers
force-pushed
the
alson-fluid-vein-jei
branch
from
bb4f33b to
cebbe67
Compare
LAGIdiot
requested changes
Jan 28, 2023
Contributor
LAGIdiot
left a comment
LAGIdiot
left a comment
There was a problem hiding this comment.
Good job extracting shared parts! I have added some more comments regarding gameplay test.
src/main/java/gregtech/integration/jei/basic/GTOreCategory.java
Outdated
Show resolved
Hide resolved
src/main/java/gregtech/integration/jei/basic/GTFluidVeinCategory.java
Outdated
Show resolved
Hide resolved
LAGIdiot
approved these changes
Feb 4, 2023
Contributor
LAGIdiot
left a comment
LAGIdiot
left a comment
There was a problem hiding this comment.
Thanks for finishing this PR!
TechLord22
requested changes
Feb 5, 2023
TechLord22
approved these changes
Feb 10, 2023
MrKono
added a commit
to MrKono/GregTech
that referenced
this pull request
Feb 11, 2023
ALongStringOfNumbers
pushed a commit
that referenced
this pull request
Feb 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
This PR creates a basic Fluid Vein JEI page, since one was missing for a while.
Currently the implementation is very basic, but more things can be added.
Implementation Details:
This page can be accessed by clicking on the fluid or the bucket of fluid in JEI.
Each piece of text displayed has hover tooltips for showing more information on the certain section that is being hovered over.
Outcome:
Creates a Fluid Vein JEI Page