Yet another Crafting station fix PR #1255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
really helps with shapeless recipes
src/main/java/gregtech/common/metatileentities/storage/CachedRecipeData.java
Outdated
Show resolved
Hide resolved
ALongStringOfNumbers
approved these changes
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Yet another Crafting Station Issue F I X.
This time fix the issue with Shapeless Recipes Murdering the server performance, when the Crafting Station is surrounded by inventories with many slots
Also made recipe re-matching stricter to avoid issue with recipes with NBT-dependent inputs not correctly updating the output.
(Like potion arrows)
Implementation Details
Implement a cache for the tested stacks for the current recipe while also testing them individually against the ingredients before calling the recipe matches() method to avoid the recursion of Shapeless recipes
Outcome
Game is playable while a shapeless recipe is on the crafting station's crafting grid
Additional Information
Fixes #1235, and hopefully #935
Potential Compatibility Issues
This section is for defining possible compatibility issues. It must be used when there are API changes, item/block/material/machine changes, or recipe changes.
Please fill in as much useful information as possible. Also, please remove all unused sections, including this and the other explanations.