Change the implementation of transformers#13
Merged
serenibyss merged 5 commits intoGregTechCEu:masterfrom Jul 6, 2021
Merged
Conversation
hjae78
suggested changes
Jul 3, 2021
| } else { | ||
| Textures.ENERGY_IN_MULTI.renderSided(getFrontFacing(), renderState, translation, PipelineUtil.color(pipeline, GTValues.VC[getTier()])); | ||
| Textures.ENERGY_OUT.renderSided(getFrontFacing().getOpposite(), renderState, translation, PipelineUtil.color(pipeline, GTValues.VC[getTier() - 1])); | ||
| if (frontFacing == EnumFacing.NORTH) { |
Contributor
There was a problem hiding this comment.
This code is too messy, we need to cut it down by a lot
Member
|
This PR needs a rebase, it is hard to tell what has actually changed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Changes the implementation of transformers. If going down all sides but north will be for outputting energy. If going up all sides but the north side will be for inputting energy. Transformer overlays have also been updated to reflect this.
How solved:
Instead of using the method getFrontFacing() and getOpposite() I am using forge directions to decide the sidedness of rendering.
Outcome:
Outputting energy when going down and inputting energy when going up is no longer one sided.
Possible compatibility issue:
With more sides now acting as an output or input. peoples setups may break deepening on previous transformer placements