Fix incorrect event handler registration#1520
Merged
TechLord22 merged 1 commit intoGregTechCEu:masterfrom Feb 21, 2023
Merged
Conversation
Contributor
|
The chest gen hooks issue was probably because Tech made the subscribeEvent static in his probable bugs PR. Does simply making the SubscribeEvent not static fix the issue? |
Contributor
Author
|
I chose to modify the registration method and keep the event handler static because there was no usage of |
ALongStringOfNumbers
approved these changes
Feb 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This PR fixes a part of event handler registration broken in a recent commit. Additionally, this PR removes one unnecessary registration.
Outcome
worldgen.addLootoption andworldgen.increaseDungeonLootoption, which broke due to the incorrect event handler registration, will work again.Additional Information
I've looked into every occurrence of
MinecraftForge.EVENT_BUS.registeron the project and deemed there was no further issues. At least on surface level.