Merged
Conversation
LAGIdiot
approved these changes
Mar 3, 2023
Contributor
LAGIdiot
left a comment
LAGIdiot
left a comment
There was a problem hiding this comment.
Implementation seems reasonable.
ALongStringOfNumbers
approved these changes
Mar 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This PR fixes two issues with electric tools.
First, it fixes issues found in
ShapedOreEnergyTransferRecipe. It previously attempted to charge the output item before overriding its max charge. In cases where there was only one item to transfer charge from, it would be transferred before setting the maximum charge. This can be seen when crafting tools using power units with higher maximum charges than the default power unit. This PR fixes this bug.The second issue fixed is related to electric tools breaking. When electric tools broke, the power unit stack dropped would have the default maximum charge. This PR fixes this by overriding the maximum charge to be the same as the tool's.
Outcome
Fixes issues with electric tools. Closes #1484.