Use minecraft logic for tool durability bar #1648
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tictim
requested changes
Apr 12, 2023
Tictim
reviewed
Apr 13, 2023
Contributor
|
The first fix for the durability being inverted from vanilla is fine, however always showing the durability bar was a purposeful decision that should remain the way it is |
Member
Author
|
Do you want to elaborate as to why? |
Tictim
approved these changes
May 23, 2023
Contributor
Tictim
left a comment
Tictim
left a comment
There was a problem hiding this comment.
Impl looks fine. For durability bar visibility I think hiding it on full durability like vanilla is both more intuitive and beneficial during gameplay.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Minecraft logic for durability is 0/ is full durability, show showing the durability bar, we were doing the opposite.
This had the effect of causing durability mods that use the durability rgb for that tool to be opposite of what is should, red instead of green.
Also made it so the durability bar is not shown if the tool is not damaged.
Outcome