Merged
Conversation
Contributor
There was a problem hiding this comment.
this should be set after here, unless we refactor this to look more like the logic in AbstractRecipeLogic, where the result of findRecipe is already looped through the tank list
Contributor
There was a problem hiding this comment.
we can clear after the loop end, so we call clear only once
ALongStringOfNumbers
force-pushed
the
FuelLogic
branch
from
7b22afc to
c90d522
Compare
TechLord22
requested changes
Oct 17, 2021
TechLord22
approved these changes
Oct 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
An attempt to rework some of FuelRecipeLogic, moving the obstructed information away from structure formation, and into the update check. Also attempts to implement Trouser's notifiable system for FuelRecipeLogic (only the fluids, not items).
Adds an
isObstructedmethod toFuelRecipeLogicfor multiblocks to override if needed. This method will be checked every tick, and when attempting to start a new recipe.Moves the maintenance check up to
isReadyForRecipesIn the Large Combustion Engine workable, adds a method to check if the engine intakes are free, modeled after the Large Turbine one. Both of these methods will need to be updated for the Freedom wrench to account for facing upwards.
Adds a line to the TOP pane that shows if the structure is obstructed.
Feedback:
I desire some feedback on some parts of this PR, most of which I have left as TODO's in the code. The main thing is if the
isObstructed()check should be run every tick, or on some sort of timer, to prevent scanning the space in front of the multiblock every tick.Outcome:
Slight FuelRecipeLogic rework