Add Custom Tank Scaling for Machines#167
Merged
serenibyss merged 2 commits intomasterfrom Sep 29, 2021
Merged
Conversation
serenibyss
approved these changes
Sep 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
This PR adds the ability to scale the tank size of machines based on the machine's tier. There are two functions by default. The default function scales: 8, 12, 16, 32, 64 from ULV/LV to IV. The alternative scales: 8, 12, 16, 16, 16 from ULV/LV to IV. The second one is intended for things like chemical reactors and assemblers, which do not need massive fluid buffers. More functions are also easy to add for specific machines if desired.
How solved:
An additional parameter to WorkableTieredMetaTileEntity was added, which is a function used to determine the size of the fluid tanks.
Outcome:
Allows machines to have their tank sizes scale with their tier using a custom function.