Fix material model breaking with resource reload#1702
Merged
TechLord22 merged 3 commits intoGregTechCEu:masterfrom Apr 29, 2023
Merged
Fix material model breaking with resource reload#1702TechLord22 merged 3 commits intoGregTechCEu:masterfrom
TechLord22 merged 3 commits intoGregTechCEu:masterfrom
Conversation
Tictim
added
type: bug
TechLord22
approved these changes
Apr 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This PR fixes issues related to material models breaking with resource reload.
Implementation Details
This PR changes timing of the cache disposal to prevent wrong value getting used during model registration. The block model locations are also included in cache refresh.
Potential Compatibility Issues
None