Merged
Conversation
TechLord22
approved these changes
Apr 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Some mods, such as NoTreePunching, seem to depend on certain blocks having harvest tools to function as expected, but some GT blocks like wood logs do not currently have harvest tools assigned. This PR aims to fix these blocks.
Implementation Details
One could look for any blocks that I've missed, and furthermore, BlockFoam's harvest tool could be changed (although I think it should still stay).
Outcome
Adds proper harvest tools to GT logs (fixing NoTreePunching compatibility)
Potential Compatibility Issues
In the case that any mods depended on these blocks not having harvest tools, they would be broken by this mod.