Small refactor for drawing recipe properties on JEI#1718
Merged
serenibyss merged 2 commits intoGregTechCEu:masterfrom Apr 22, 2023
Merged
Small refactor for drawing recipe properties on JEI#1718serenibyss merged 2 commits intoGregTechCEu:masterfrom
serenibyss merged 2 commits intoGregTechCEu:masterfrom
Conversation
ALongStringOfNumbers
added
the
type: refactor
TechLord22
approved these changes
Apr 20, 2023
src/main/java/gregtech/api/recipes/recipeproperties/RecipeProperty.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This PR does some refactor for drawing recipe properties on JEI.
Implementation Details
Move some private methods in
GTRecipeWrapperandRecipeMapCategoryto public method onRecipeMap, so that recipemaps can override them.Outcome
Allow more customizability for drawing
RecipePropertyon JEI.Additional Information
One property is used to draw two lines in this recipemap.
Potential Compatibility Issues
Removed only private methods, no incompatibility expected