Show name of locked fluid in Quantum Tank#1733
Merged
TechLord22 merged 2 commits intomasterfrom May 1, 2023
Merged
Conversation
TechLord22
reviewed
May 1, 2023
Member
TechLord22
left a comment
TechLord22
left a comment
There was a problem hiding this comment.
Unraveling these ternaries into regular if statements would be appreciated.
|
|
||
| private Consumer<List<ITextComponent>> getFluidNameText(TankWidget tankWidget) { | ||
| return (list) -> { | ||
| String fluidName = tankWidget.getFluidLocalizedName().isEmpty() ? this.lockedFluid != null ? this.lockedFluid.getLocalizedName() : "" : tankWidget.getFluidLocalizedName(); |
Member
There was a problem hiding this comment.
In the cases where this ternary and the one below result in "", should adding to the list be prevented entirely, instead of adding the empty string?
TechLord22
approved these changes
May 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Always shows the fluid name of locked fluids on Quantum Tanks, even when all fluid has been extracted, but the tank is still locked. Closes #1693
Outcome
Always show locked fluid information on quantum tanks