Allow matching any or no nbt tag in CT#1737
Merged
TechLord22 merged 2 commits intomasterfrom May 7, 2023
Merged
Conversation
TechLord22
added
integration: CT
serenibyss
approved these changes
May 2, 2023
Contributor
|
This seems to be the behaviour already, with adding |
|
This Pull Request has automatic artifact deployment enabled. Download the latest build here, and extract the contents. |
bruberu
approved these changes
May 6, 2023
Member
bruberu
left a comment
bruberu
left a comment
There was a problem hiding this comment.
This appears to have fixed ALSON's concern about not using the new matching in evaluate, and I don't think it's problematic.
ALongStringOfNumbers
approved these changes
May 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Allows CT to have inputs which match any or no NBT tag. This behavior is created when the input is provided with an empty NBT tag, which is consistent with how CT interacts with other mods.
Documentation for this behavior will be added to the wiki as well.
Outcome
Fixes #1688.