Merged
Conversation
2 tasks
serenibyss
approved these changes
May 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This PR makes changes to how multiblocks handle energy inputs.
First,
EnergyContainerListhas been modified to better handle its voltage and amperage. These changes are better explained and reflected in the tests and implementation added with this PR, than can be done in text.Next, multiblock maximum energy inputs have been reduced from 3 to 2. This is due to the above changes, where adding a 3rd energy hatch does not change the tier of the multiblock. For example, two 2A LV inputs make an MV multiblock. But three 2A LV hatches is only 1.5A of MV, which is still considered MV for recipe logic. This applies to both overclocking and recipe search.
The Processing Array is a special case for the above energy hatch constraint, and it has been changed to have no upper maximum, to allow further recipe overclocking.
Implementation Details
All of the test cases and scenarios for voltage and amperage combinations should be covered in
EnergyContainerList, but some may have slipped through.Outcome
Fixes inconsistencies with multiblock overclocking and recipe search with multiple, potentially mixed energy hatches.
Potential Compatibility Issues
EnergyContainerListwill no longer dynamically update Input/Output Voltage and Amperage when the contents of the list changes. This should not affect anything within the base mod, but may affect addons using it.Setups using more than 2 energy hatches will break, as multiblock structures will unform.