Skip to content

Comments

Add method to register a set of custom MetaTileEntities#1851

Merged
serenibyss merged 1 commit intoGregTechCEu:masterfrom
miozune:feature/register-mtes
Jul 11, 2023
Merged

Add method to register a set of custom MetaTileEntities#1851
serenibyss merged 1 commit intoGregTechCEu:masterfrom
miozune:feature/register-mtes

Conversation

@miozune
Copy link
Contributor

@miozune miozune commented Jun 14, 2023

What

This PR adds method to register a set of custom MetaTileEntities, similarly to existing method registerSimpleMetaTileEntity but for general MetaTileEntity.

Outcome

Cleanup of MetaTileEntities and QoL for addons.

@miozune miozune requested a review from a team as a code owner June 14, 2023 07:42
@ALongStringOfNumbers ALongStringOfNumbers added the type: feature New feature or request label Jun 14, 2023
@miozune miozune force-pushed the feature/register-mtes branch from a8b0ba2 to b6d8355 Compare July 8, 2023 00:56
@ALongStringOfNumbers
Copy link
Contributor

ALongStringOfNumbers commented Jul 8, 2023

I can't really see where the higher tier blockers are taken into account after your refactor. Are they still accounted for after your refactor?

@miozune
Copy link
Contributor Author

miozune commented Jul 8, 2023

I can't really see where the higher tier blockers are taken into account after your refactor. Are they still accounted for after your refactor?

These lines should be checking mid / high tiers? miozune@b6d8355#diff-b5198968204ff7e663a0c2b9e1dfc093a35073ad4c469827b77fa86648975545R837-R838

@ALongStringOfNumbers
Copy link
Contributor

ALongStringOfNumbers commented Jul 8, 2023

These lines should be checking mid / high tiers? miozune@b6d8355#diff-b5198968204ff7e663a0c2b9e1dfc093a35073ad4c469827b77fa86648975545R837-R838

Ah, I see it now. However, that will not work for the macerator, since it used different values instead of 4 and 7

@miozune
Copy link
Contributor Author

miozune commented Jul 8, 2023

Mecerator tiers are the same as registerMetaTileEntities, array MACERATOR just got shifted to the left by 1.

@serenibyss serenibyss added type: refactor Suggestion to refactor a section of code and removed type: feature New feature or request labels Jul 11, 2023
@serenibyss serenibyss merged commit 83c4bc5 into GregTechCEu:master Jul 11, 2023
@miozune miozune deleted the feature/register-mtes branch July 12, 2023 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serenibyss serenibyss serenibyss approved these changes

Assignees

No one assigned

Labels

type: refactor Suggestion to refactor a section of code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@miozune @ALongStringOfNumbers @serenibyss