Fix behavior of OreProperty#setOreByProducts#1857
Merged
TechLord22 merged 1 commit intomasterfrom Jun 19, 2023
Merged
Conversation
ALongStringOfNumbers
added
type: refactor
ALongStringOfNumbers
approved these changes
Jun 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes
OreProperty#setOreByProductsadding instead of setting. This resulted in unexpected behavior with addons attempting to modify the byproducts of a material. A new method to mimic the old behavior of addition was added as well,#addOreByProducts.Outcome
Fixes behavior of
OreProperty#setOreByProducts.Potential Compatibility Issues
Mods will likely not have relied on the old behavior, but if they did, they will need to move to the
addmethod. No compile-time incompatibilities are expected otherwise.