Add Filtering to Pump Machines#1899
Merged
serenibyss merged 15 commits intoGregTechCEu:masterfrom Jul 8, 2023
Merged
Conversation
add locked to syncdata
save locked to nbt
remove unused code
ghzdude
force-pushed
the
gh-filtered-pump-machine
branch
from
dfcb347 to
71f5e21
Compare
serenibyss
reviewed
Jul 8, 2023
src/main/java/gregtech/common/metatileentities/electric/MetaTileEntityPump.java
Outdated
Show resolved
Hide resolved
serenibyss
approved these changes
Jul 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Allows users to filter what the pump machine can extract from in-world fluids
Implementation Details
Switches the TankWidget with a PhantomTankWidget, for filtering
Adds a lock button to the pump machine
Outcome
Users can filter the pump machine
Additional Information
Potential Compatibility Issues
none afaik